fix: Fix MacOS path resolution failures and surface temp directory cleanup errors #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unnecessary _normalize_path(path.resolve()) calls, using path directly for ingestion - Remove ignore_errors=True from shutil.rmtree to allow proper error reporting
filipchristiansen
force-pushed
the
refactor/remove-redundant-path-resolution
branch
from
b21cc74 to
070121c
Compare
cyclotruc
approved these changes
Feb 17, 2025
filipchristiansen
deleted the
refactor/remove-redundant-path-resolution
branch
filipchristiansen
added a commit
that referenced
this pull request
Mar 13, 2025
- Remove unnecessary _normalize_path(path.resolve()) calls, using path directly for ingestion - Remove ignore_errors=True from shutil.rmtree to allow proper error reporting
filipchristiansen
added a commit
that referenced
this pull request
Mar 13, 2025
- Remove unnecessary _normalize_path(path.resolve()) calls, using path directly for ingestion - Remove ignore_errors=True from shutil.rmtree to allow proper error reporting Signed-off-by: Filip Christiansen <22807962+filipchristiansen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the redundant
_normalize_path(path.resolve())calls inquery_ingestion.py,which were causing ingestion to fail on MacOS.
Removes
ignore_errors=Truefromshutil.rmtreeto enable error handling during temporary directory cleanup.